Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate hardcoded images to Maven properties #998

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Migrate hardcoded images to Maven properties #998

merged 1 commit into from
Dec 22, 2023
+23 −15

Conversation

gtroitsk
Copy link
Member

@gtroitsk gtroitsk commented Dec 21, 2023 •
edited
Loading

Summary

Migrates all hardcoded images with versions into POM

It is not possible to get rid of hardcoded images in JaegerContainer, KeycloakContainer, AmqContainer, because FW system properties will be ignored while using them in TS

Please check the relevant options

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Dependency update
  • Refactoring
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • This change requires execution against OCP (use run tests phrase in comment)

Checklist:

  • Example scenarios has been updated / added
  • Methods and classes used in PR scenarios are meaningful
  • Commits are well encapsulated and follow the best practices

@michalvavrik
Copy link
Member

Migrates all hardcoded images with versions into BOM

POM

@gtroitsk
Copy link
Member Author

run tests

michalvavrik
michalvavrik approved these changes Dec 22, 2023
View reviewed changes
Copy link
Member

@michalvavrik michalvavrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalvavrik michalvavrik merged commit 7509557 into quarkus-qe:main Dec 22, 2023
9 checks passed
@gtroitsk gtroitsk deleted the remove-hardcoded-images branch December 22, 2023 08:43
@michalvavrik michalvavrik mentioned this pull request Jan 17, 2024
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalvavrik michalvavrik michalvavrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gtroitsk @michalvavrik